Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a release version of staticcheck in ci.yml #819

Merged
merged 2 commits into from
Dec 3, 2023

Conversation

pnacht
Copy link
Contributor

@pnacht pnacht commented Nov 16, 2023

I noticed the ci.yml workflow uses honnef.co/go/tools/cmd/staticcheck@master and mentions that it should be replaced by a specific version once an issue in that dependency is fixed.

It was fixed earlier this year, in release 0.4.1. This PR adopts the latest release version (0.4.6). Let me know if you'd rather just use 0.4.1.

@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f3a68a3) 66.99% compared to head (489f18c) 66.99%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #819   +/-   ##
=======================================
  Coverage   66.99%   66.99%           
=======================================
  Files          45       45           
  Lines        9861     9861           
=======================================
  Hits         6606     6606           
  Misses       2795     2795           
  Partials      460      460           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aalexand aalexand merged commit ad67f76 into google:main Dec 3, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants